fix(zhipu): mark truncated responses - #3883
Open
Shizoqua wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark Zhipu responses ending with
finish_reason="length"as truncated.Problem
Token-limited responses could be cached as complete.
Changes
Wrap truncated Zhipu output in
TruncatedResponse.Testing
Zhipu tests: 15 passed
Pre-commit: passed
git diff --check: passedCompatibility and Risk
Low risk. Response text remains unchanged.
Related Issue
No related issue.